-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add -Z unpretty
flags for the AST
#82304
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Feb 19, 2021
3 tasks
r=me based purely on the last commit, after the FCP is completed. |
camelid
added
the
S-blocked
Status: Blocked on something else such as an RFC or other implementation work.
label
Feb 19, 2021
Marking as blocked on #82269. |
7 tasks
spastorino
approved these changes
Feb 23, 2021
LeSeulArtichaut
removed
the
S-blocked
Status: Blocked on something else such as an RFC or other implementation work.
label
Mar 3, 2021
rust-lang/compiler-team#408 was accepted and #82269 was merged, so this is now unblocked. |
LeSeulArtichaut
added
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
A-pretty
Area: Pretty printing (including `-Z unpretty`)
labels
Mar 3, 2021
LeSeulArtichaut
force-pushed
the
unpretty-ast
branch
from
March 3, 2021 14:11
c6fc328
to
6111445
Compare
Rebased. |
@bors r+ |
📌 Commit 6111445 has been approved by |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Mar 3, 2021
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Mar 4, 2021
…storino Add `-Z unpretty` flags for the AST Implements rust-lang/compiler-team#408. Builds on rust-lang#82269, but if that PR is rejected or stalls out, I can implement this without rust-lang#82269. cc rust-lang/rustc-dev-guide#1062
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-pretty
Area: Pretty printing (including `-Z unpretty`)
merged-by-bors
This PR was explicitly merged by bors.
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements rust-lang/compiler-team#408.
Builds on #82269, but if that PR is rejected or stalls out, I can implement this without #82269.
cc rust-lang/rustc-dev-guide#1062