Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -Z unpretty flags for the AST #82304

Merged
merged 1 commit into from
Mar 4, 2021

Conversation

LeSeulArtichaut
Copy link
Contributor

Implements rust-lang/compiler-team#408.
Builds on #82269, but if that PR is rejected or stalls out, I can implement this without #82269.
cc rust-lang/rustc-dev-guide#1062

@rust-highfive
Copy link
Collaborator

r? @matthewjasper

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 19, 2021
@estebank
Copy link
Contributor

r=me based purely on the last commit, after the FCP is completed.

@camelid camelid added the S-blocked Status: Blocked on something else such as an RFC or other implementation work. label Feb 19, 2021
@camelid
Copy link
Member

camelid commented Feb 19, 2021

Marking as blocked on #82269.

@LeSeulArtichaut LeSeulArtichaut removed the S-blocked Status: Blocked on something else such as an RFC or other implementation work. label Mar 3, 2021
@LeSeulArtichaut
Copy link
Contributor Author

rust-lang/compiler-team#408 was accepted and #82269 was merged, so this is now unblocked.

@LeSeulArtichaut LeSeulArtichaut added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. A-pretty Area: Pretty printing (including `-Z unpretty`) labels Mar 3, 2021
@LeSeulArtichaut
Copy link
Contributor Author

Rebased.

@spastorino
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Mar 3, 2021

📌 Commit 6111445 has been approved by spastorino

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 3, 2021
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Mar 4, 2021
…storino

Add `-Z unpretty` flags for the AST

Implements rust-lang/compiler-team#408.
Builds on rust-lang#82269, but if that PR is rejected or stalls out, I can implement this without rust-lang#82269.
cc rust-lang/rustc-dev-guide#1062
@bors
Copy link
Contributor

bors commented Mar 4, 2021

⌛ Testing commit 6111445 with merge 7f32f62...

@bors
Copy link
Contributor

bors commented Mar 4, 2021

☀️ Test successful - checks-actions
Approved by: spastorino
Pushing 7f32f62 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 4, 2021
@bors bors merged commit 7f32f62 into rust-lang:master Mar 4, 2021
@rustbot rustbot added this to the 1.52.0 milestone Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-pretty Area: Pretty printing (including `-Z unpretty`) merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants